Upgrade opa deps to 1.0 and get tests passing #2274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPA v1.0 has for backwards compatility to help people migrate. So all the deps except for cmd and internal are now under the v1 package.
simonbaird
force-pushed
the
opa-1.0-upgrade
branch
from
fe5cd20 to
667b680
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
=======================================
Coverage 72.76% 72.76%
=======================================
Files 89 89
Lines 7674 7674
=======================================
Hits 5584 5584
Misses 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more.
|
simonbaird
added a commit
to simonbaird/ec-cli
that referenced
this pull request
Jan 21, 2025
The idea here is that once we update to opa 1.0 we'll need to always use the new `deny contains foo if` syntax. This change is supposed to make it easier by using that syntax consistently now. It requires importing `rego.v1` everywhere, but we do that consistently for all the rego in ec-policies, so let's also do it here also. See also enterprise-contract#2274 which I'd like to rebase on this once it's merged.
|
I split some of this into #2281 which could be merged early. |
|
Re conftest and opa 1.0 support, I found open-policy-agent/conftest#1032 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably want to also update conftest, so this is a draft for now. I'm pushing it to see if the acceptance tests will pass.
One idea: The "Use v1 compatible
ifsyntax.." commit can be split out and merged early I think.